Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build aarch64 musllinux wheel #69

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

harryzcy
Copy link
Contributor

@harryzcy harryzcy commented Feb 27, 2024

super-linter is preparing for arm64 support super-linter/super-linter#5070. It would be very helpful to have a musllinux_aarch64 wheel

Fix #41

@harryzcy
Copy link
Contributor Author

harryzcy commented Mar 2, 2024

@arigo @nitzmahone Can you help to review this? Thank you

@arigo arigo requested a review from nitzmahone March 3, 2024 06:07
@harryzcy
Copy link
Contributor Author

harryzcy commented Mar 18, 2024

The CI is passing on my fork. See https://github.com/harryzcy/cffi/actions/runs/8071125490

Can you help to approve the CI workflow? or is there anything blocking? Thanks

@arigo
Copy link
Contributor

arigo commented Mar 18, 2024

I have no idea how .github/workflows/ci.yaml works, but if Matt cannot do the review for the time being, I would be happy to accept your PR with just a few words from you: it looks like it's only adding support to run on some extra CI system of github, right? Is there any side-effect to take into account for us?

@arigo arigo closed this Mar 18, 2024
@arigo arigo reopened this Mar 18, 2024
@harryzcy
Copy link
Contributor Author

it looks like it's only adding support to run on some extra CI system of github, right?

Yes

Is there any side-effect to take into account for us?

I'm not aware of any. I don't think it effects existing wheels for other os/architecture, since the build happens separately for each system.

Thanks

@arigo arigo merged commit 56f7609 into python-cffi:main Mar 18, 2024
65 checks passed
@harryzcy harryzcy deleted the musllinux-aarch64 branch March 18, 2024 23:12
@harryzcy
Copy link
Contributor Author

@arigo Thanks!

@arigo
Copy link
Contributor

arigo commented Mar 18, 2024

:-)

@nitzmahone
Copy link
Member

Sorry, been buried the past few weeks leading up to a vacation (first day back)...

I should've commented earlier: I'd been trying to avoid adding new support for wheel builds on arches where we don't have native builders. The full test suite is prohibitively slow on emulated builds (and Windows, for reasons I still haven't had time to investigate), so these wheels will be effectively untested beyond the very tiny slice of the test suite that we run on the Windows wheels and anything non-Intel or Apple Silicon. Caveat Emptor 😉

@nitzmahone
Copy link
Member

PS, been working a bit with @samdoran on fixing up the test fixture isolation to work properly with pytest-xdist - that should allow us to run the tests much faster in parallel worker processes.

@harryzcy
Copy link
Contributor Author

harryzcy commented Mar 19, 2024

Unrelated to this PR, macos-14 would provide Apple Silicon and it has no intel-mac as a standard GitHub runner. I don't see how other linux non-intel arches would be possible without emulation.

@strayge strayge mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aarch64 musllinux wheel
3 participants