Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for complex types with MSVC, called _Fcomplex and _Dcomplex #57

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

arigo
Copy link
Contributor

@arigo arigo commented Feb 7, 2024

No description provided.

@arigo arigo self-assigned this Feb 7, 2024
@arigo arigo marked this pull request as draft February 7, 2024 10:17
@arigo arigo marked this pull request as ready for review February 7, 2024 10:52
@chris-hld
Copy link

Fixes #56 for my setup.

@mattip
Copy link
Contributor

mattip commented Feb 7, 2024

Should this be adapted as a PR to the PyPy backend as well?

@arigo
Copy link
Contributor Author

arigo commented Feb 7, 2024

@mattip Good point! I think a minimal change would be to copy the 2 lines added to each of commontypes.c and parse_c_type.c. PyPy uses these C files directly in pypy/module/_cffi_backend/src/. I think that's all that is required. Some of the tests can also be ported, though. I can give it a try (which mostly means trying to use github to make a PR to a large project like PyPy over a not-always-fast Internet connection).

@mattip
Copy link
Contributor

mattip commented Feb 8, 2024

I can give it a try

Thanks. I opened pypy/pypy#4890 to track the problem and marked it for the next release.

@arigo arigo merged commit 4d660b1 into python-cffi:main Feb 8, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants