-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make catalog header updating an option #320
Conversation
Current coverage is
|
@akx needs more test coverage. |
Tested this locally and it works as expected - fixes issue #318 in my setup. Thanks! |
I can also just remove the new option in the distutils code, but that seems like doing it just to make Codecov happy, and we're not writing code for CI robots. :) |
59831b5
to
672f96c
Compare
Hey @ajaeger, if you have the time, could you check that this branch still works for your UC (after it was rebased)? Thank you! |
The change in e0e7ef1 had an unexpected and likely undesired effect when updating catalogs with, e.g. translator names in the header comment. It's better to make the updating an option and revert back to the pre-2.2 behavior by default. Fixes python-babel#318
Make catalog header updating an option
@akx tested current head that includes the patch and it works fine. Thanks |
The change in e0e7ef1 had an unexpected and likely undesired effect
when updating catalogs with, e.g. translator names in the header comment.
It's better to make the updating an option and revert back to the pre-2.2
behavior by default.
Fixes #318