Improve method annotations

[layday]

When registering an unstructure hook the type checker is not able to
infer the type of T; Pyright considers its type to be unknown
(eq. to object). When attempting to call a method on T a type error
is produced.

[Tinche]

Some special types like unions and optionals aren't covered by type[T], so these cannot be annotated like this. They used to be, a few versions back, but I had to revert it. We'd need something like python/mypy#9773 to get accepted and merged first.

[Tinche]

See also #111

[layday]

Thanks for explaining. Would it be possible to use Any instead of a type variable to avoid having to silence the resultant type errors? Sent with [ProtonMail](https://protonmail.com/) secure email.

…

------- Original Message -------

On Tuesday, April 26th, 2022 at 13:42, Tin Tvrtković ***@***.***> wrote: See also [#111](#111) — Reply to this email directly, [view it on GitHub](#259 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AHNRFWFVJJ3NDKPH6NSLQG3VG7CC3ANCNFSM5UK6QZSQ). You are receiving this because you authored the thread.Message ID: ***@***.***>

[Tinche]

Sure, where would you like the Any?

[layday]

In register_unstructure_hook, replacing the stand-alone type variable. It would also be helpful to annotate the unstructure_as parameter of unstructure with Optional[Any].

[Tinche]

I tweaked the annotations. I don't think Optional[Any] makes sense though (Any already contains None), so I just annotated it as Any.

[layday]

Great, thanks!

I don't think Optional[Any] makes sense though (Any already contains None)

Well, it conveys intent, even if Optional[Any] < Any.