Fix typo causing cache hash serialization test to not test the right thing. #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync to main attrs repo
Sync up to attrs master
Sync up to main attrs repository
Sync up to main repo
Sync with main repository Co-authored-by: Serhii A <[email protected]> Co-authored-by: Hynek Schlawack <[email protected]> Co-authored-by: David Euresti <[email protected]> Co-authored-by: Joshua Oreman <[email protected]> Co-authored-by: Juan Pedro Fisanotti <[email protected]> Co-authored-by: wouter bolsterlee <[email protected]> Co-authored-by: Kurt Rose <[email protected]> Co-authored-by: Julian Berman <[email protected]> Co-authored-by: John Belmonte <[email protected]> Co-authored-by: Bruno Oliveira <[email protected]> Co-authored-by: Hlynur Freyr Jónsson <[email protected]> Co-authored-by: Philippe Ombredanne <[email protected]> Co-authored-by: Matt Bullock <[email protected]> Co-authored-by: Tim Gates <[email protected]> Co-authored-by: Kyle Altendorf <[email protected]> Co-authored-by: Paul Ganssle <[email protected]>
The typo caused it to test the serialization of a class object, not the relevant instance object.
gabbard
force-pushed
the
489-fix-test-typo
branch
from
aaa77c8 to
5405dad
Compare
|
Pretty sure this will be obsoleted by #620? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a typo in a test from #489 where we tested serialization of a class object rather than of an instance of that class.
The test passed both before and after this fix.
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
.pyi).tests/typing_example.py.docs/api.rstby hand.@attr.s()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives..rstfiles is written using semantic newlines.changelog.d.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!