Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sentence parsing #470

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Conversation

skorokithakis
Copy link
Contributor

I've always parsed this sentence as "attrs comes with serious, business aliases". I just realized you probably meant srs bzns aliases and figured I'd clarify.

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

  • Added tests for changed code.
  • New features have been added to our Hypothesis testing strategy.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file tests/typing_example.py.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changes to the signature of @attr.s() have to be added by hand too.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
  • Documentation in .rst files is written using semantic newlines.
  • Changes (and possible deprecations) have news fragments in changelog.d.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

I've always parsed this sentence as "attrs comes with serious, business aliases". I just realized you probably meant srs bzns aliases and figured I'd clarify.
@wsanchez
Copy link

wsanchez commented Dec 6, 2018

Well, this requires research.

Grammar Monster seems to agree, says that a compound adjective (as opposed to two adjectives that each apply) should be hyphenated for clarity… and with a name like Grammar Monster, it's hard to argue.

So the question is whether @hynek meant that the aliases are both serious aliases and business aliases or whether he meant that they are "serious business" aliases. I've always assumed the latter, in which case this PR is correct.

I'll leave it to @hynek to confirm. :-)

@wsanchez wsanchez requested a review from hynek December 6, 2018 17:35
@skorokithakis
Copy link
Contributor Author

Thank you for the extensive research, this echoes my thinking perfectly. We cannot make this change lightheartedly, so I salute your efforts to that end.

@hynek
Copy link
Member

hynek commented Dec 7, 2018

Obviously, I meant srs bzns duh. ;)

@hynek hynek merged commit 9bed98c into python-attrs:master Dec 7, 2018
@hynek
Copy link
Member

hynek commented Dec 7, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants