Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent ImportError due to scikit-optimize and sklearn incompatibility #278

Merged
merged 3 commits into from
May 20, 2020
Merged

prevent ImportError due to scikit-optimize and sklearn incompatibility #278

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8429ee7
prevent ImportError due to scikit-optimize and sklearn incompatibility
basnijholt May 20, 2020
b71c6e8
add todo
basnijholt May 20, 2020
c70b3ac
link the upstream issue
basnijholt May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions adaptive/tests/test_learners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
try:
from adaptive.learner.skopt_learner import SKOptLearner
except (ModuleNotFoundError, ImportError):
# XXX: catch the ImportError because of https://github.com/python-adaptive/adaptive/pull/278
basnijholt marked this conversation as resolved.
Show resolved Hide resolved
SKOptLearner = None


Expand Down