Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for loky #263

Merged
merged 12 commits into from
Apr 10, 2020
Merged

add support for loky #263

merged 12 commits into from
Apr 10, 2020

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Apr 9, 2020

Description

This adds support for loky which has a ProcessPoolExecutor that can for example use cloudpickle.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@basnijholt basnijholt requested a review from jbweston April 9, 2020 16:15
@codecov-io
Copy link

codecov-io commented Apr 9, 2020

Codecov Report

Merging #263 into master will increase coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   79.42%   79.44%   +0.02%     
==========================================
  Files          32       32              
  Lines        4403     4423      +20     
  Branches      811      815       +4     
==========================================
+ Hits         3497     3514      +17     
- Misses        778      781       +3     
  Partials      128      128              
Impacted Files Coverage Δ
adaptive/runner.py 65.18% <64.70%> (-0.58%) ⬇️
adaptive/tests/test_runner.py 92.20% <100.00%> (+0.77%) ⬆️
adaptive/learner/learner2D.py 78.38% <0.00%> (+0.36%) ⬆️
adaptive/learner/learner1D.py 92.33% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b5620...db051be. Read the comment docs.

Copy link
Contributor

@jbweston jbweston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo test failures

adaptive/runner.py Show resolved Hide resolved
adaptive/runner.py Show resolved Hide resolved
@basnijholt
Copy link
Member Author

I've opened joblib/loky#240.

@basnijholt
Copy link
Member Author

basnijholt commented Apr 10, 2020

@jbweston, I think the remaining failures are related to https://bugs.python.org/issue36281 and #156.

Not sure how to tackle these.

I've opened joblib/loky#241.

@basnijholt basnijholt merged commit df91ebb into master Apr 10, 2020
@basnijholt basnijholt deleted the support-loky branch April 18, 2020 13:51
@basnijholt basnijholt mentioned this pull request May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants