Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color the overhead between red and green #252

Merged
merged 1 commit into from
Dec 18, 2019
Merged

color the overhead between red and green #252

merged 1 commit into from
Dec 18, 2019

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Dec 18, 2019

Description

The color of the reported overhead will change to red if it's bad and to green if it's good.

ezgif com-video-to-gif

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@codecov-io
Copy link

Codecov Report

Merging #252 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #252      +/-   ##
=========================================
- Coverage   79.54%   79.5%   -0.04%     
=========================================
  Files          32      32              
  Lines        4399    4402       +3     
  Branches      809     809              
=========================================
+ Hits         3499    3500       +1     
- Misses        774     777       +3     
+ Partials      126     125       -1
Impacted Files Coverage Δ
adaptive/notebook_integration.py 18.18% <0%> (-0.43%) ⬇️
adaptive/learner/learner2D.py 78.38% <0%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9529398...656bb56. Read the comment docs.

@basnijholt basnijholt requested a review from jbweston December 18, 2019 17:04
Copy link
Contributor

@jbweston jbweston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbweston jbweston merged commit 0015410 into master Dec 18, 2019
@basnijholt basnijholt mentioned this pull request Jan 16, 2020
@basnijholt basnijholt deleted the color-overhead branch April 18, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants