Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the style of the live_info widget, closes #250 #251

Merged
merged 1 commit into from
Dec 18, 2019
Merged

improve the style of the live_info widget, closes #250 #251

merged 1 commit into from
Dec 18, 2019

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Dec 18, 2019 •
edited
Loading

Description

Based on the default style of the Jupyterlab table.

In Jupyterlab:
image

In the notebook:
image

Fixes #250

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@basnijholt
improve the style of the live_info widget, closes #250
99b2aee 
Based on the default style of the Jupyterlab table.
jbweston
jbweston approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@jbweston jbweston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@basnijholt basnijholt merged commit 9529398 into master Dec 18, 2019
@basnijholt basnijholt deleted the prettier-live-info branch December 18, 2019 16:41
@basnijholt basnijholt mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbweston jbweston jbweston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

live_info looks is badly formatted in Jupyterlab
2 participants
@basnijholt @jbweston