Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tox, closes #238 #247

Merged
merged 32 commits into from
Dec 18, 2019
Merged

use tox, closes #238 #247

merged 32 commits into from
Dec 18, 2019

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Dec 16, 2019

Adds tox.

Summary of changes

  • Use tox.ini for all configuration
  • Test against Python 3.6, 3.7, and 3.8
  • Tests on Windows, macOS, and Ubuntu
  • Run tests with the bare dependencies (so only the bare requirements)
  • Upload Coverage reports to codecov.io
  • Define dependencies all in setup.py
  • Removes double occurrence of the pipelines
  • Adds flaky to tests that sometimes fail
  • Several small fixes in the tests
  • Use ProcessPoolExecutor by default for Windows because it seems to work

Notes

@basnijholt basnijholt mentioned this pull request Dec 16, 2019
@basnijholt basnijholt force-pushed the tox branch 28 times, most recently from ddb7299 to 5be55b0 Compare December 16, 2019 20:56

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@basnijholt basnijholt force-pushed the tox branch 4 times, most recently from 2000865 to a565013 Compare December 17, 2019 16:49
Copy link
Contributor

@jbweston jbweston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jbweston jbweston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbweston jbweston merged commit f98e063 into master Dec 18, 2019
@jbweston jbweston deleted the tox branch December 18, 2019 12:19
@basnijholt basnijholt mentioned this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants