-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use tox, closes #238 #247
Merged
use tox, closes #238 #247
+245
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
basnijholt
force-pushed
the
tox
branch
28 times, most recently
from
December 16, 2019 20:56
ddb7299
to
5be55b0
Compare
basnijholt
force-pushed
the
tox
branch
4 times, most recently
from
December 17, 2019 16:49
2000865
to
a565013
Compare
In 890f84c I wrote that a 'concurrent.futures.ProcessPoolExecutor' doesn't work on Windows. However, it seems like it just works now.
jbweston
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jbweston
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tox.
Summary of changes
tox.ini
for all configurationsetup.py
flaky
to tests that sometimes failProcessPoolExecutor
by default for Windows because it seems to workNotes
black fails because of No module named 'regex._regex'; 'regex' is not a package psf/black#1207this is fixed