Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a time-base stopping criterion for runners #229

Merged
merged 3 commits into from
Nov 21, 2019
Merged

add a time-base stopping criterion for runners #229

merged 3 commits into from
Nov 21, 2019

Conversation

jbweston
Copy link
Contributor

Closes #184.

@jbweston jbweston requested a review from basnijholt November 21, 2019 11:59
akhmerov
akhmerov approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@akhmerov akhmerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jbweston jbweston force-pushed the feature/time-based-stop branch from 34ce0e1 to 94762f3 Compare November 21, 2019 12:05
@jbweston jbweston force-pushed the feature/time-based-stop branch from 94762f3 to cf0ab59 Compare November 21, 2019 12:23
@basnijholt
Copy link
Member

Cool!

@basnijholt basnijholt merged commit c084704 into master Nov 21, 2019
@jbweston jbweston deleted the feature/time-based-stop branch November 22, 2019 08:07
@basnijholt basnijholt mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhmerov akhmerov akhmerov approved these changes

@basnijholt basnijholt Awaiting requested review from basnijholt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time-based stop
3 participants
@jbweston @basnijholt @akhmerov