Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jupyter_sphinx v0.2.0 from conda instead of my branch #204

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Jul 10, 2019

This again needs #169. However, I have manually executed those commands from the CI.

See https://adaptive.readthedocs.io/en/test_documentation/ when the build finished.

@akhmerov
Copy link
Contributor

Let's pin jupyter-sphinx at <= 0.3, and specify the thebe config like here. Pointing to this repo should be all it takes.

@basnijholt
Copy link
Member Author

Actually, I rather pin it to a fixed version like everything else.

Is adding those lines to the config really enough to install thebelab?

Of course, it would need some buttons.

docs/source/conf.py Outdated Show resolved Hide resolved
@basnijholt
Copy link
Member Author

@akhmerov
Copy link
Contributor

Also, how would we make sure that this gets executed https://github.com/python-adaptive/adaptive/blame/master/docs/source/tutorial/tutorial.Learner1D.rst#L13-L21

These will become visible but the user will need to manually execute those.

@jbweston
Copy link
Contributor

I updated the dependency to jupyter_sphinx 0.2.1. All the other dependencies are pinned at exact version, so I think it's fine

@jbweston
Copy link
Contributor

This LGTM

@basnijholt basnijholt merged commit ac2c593 into master Jul 29, 2019
@basnijholt basnijholt deleted the sphinx branch July 29, 2019 10:20
@basnijholt basnijholt mentioned this pull request Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants