Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to display a progress bar when loading a BalancingLearner #197

Closed
wants to merge 1 commit into from

Conversation

basnijholt
Copy link
Member

This adds an option with_progress_bar to the BalancingLearner.load method.

Output example
image

I am currently trying to load 370k learners which takes more than 30 min on a slow NFS. It would be really useful to display the progress.

@basnijholt basnijholt requested a review from jbweston May 27, 2019 19:35
@basnijholt basnijholt force-pushed the with_progress_bar branch from 961a82e to 526994d Compare May 27, 2019 19:35
@basnijholt basnijholt force-pushed the with_progress_bar branch from 526994d to 671d831 Compare May 27, 2019 19:40
@akhmerov
Copy link
Contributor

I think it's a bad design to expose this to a library user: a good interface should be simple, and this is a customizable non-essential functionality that also adds an extra dependency.

@jbweston
Copy link
Contributor

I agree with Anton; I think that this is a functionality that you could implement independently from the library (given that load is very simple)

@basnijholt
Copy link
Member Author

Thanks for your feedback, I've added it to adaptive-scheduler where it makes more sense because you are dealing with many learners there.

@basnijholt basnijholt closed this Jun 20, 2019
@basnijholt basnijholt deleted the with_progress_bar branch June 20, 2019 22:34
@basnijholt basnijholt mentioned this pull request Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants