Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test pollution in test_assertrewrite #9641

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix test pollution in test_assertrewrite #9641

merged 1 commit into from
Feb 8, 2022

Conversation

asottile
Copy link
Member

@asottile asottile commented Feb 8, 2022

originally reproduced with this pollution set:

testing/test_assertrewrite.py::TestEarlyRewriteBailout::test_pattern_contains_subdirectories
testing/test_assertrewrite.py::TestRewriteOnImport::test_remember_rewritten_modules

originally reproduced with this pollution set:

```
testing/test_assertrewrite.py::TestEarlyRewriteBailout::test_pattern_contains_subdirectories
testing/test_assertrewrite.py::TestRewriteOnImport::test_remember_rewritten_modules
```
@nicoddemus
Copy link
Member

Great find!

originally reproduced with this pollution set:

How are you finding these?

@asottile
Copy link
Member Author

asottile commented Feb 8, 2022

Great find!

originally reproduced with this pollution set:

How are you finding these?

I found this one while fixing the other one. basically get the test list and bisect the list with the falling test (maybe I'll make a video about it, or write some automation -- I wrote a tool for this for testify based tests previously)

@asottile asottile merged commit efa16c2 into pytest-dev:main Feb 8, 2022
@asottile asottile deleted the fix-test-pollution-assertrewrite branch February 8, 2022 13:34
@nicoddemus
Copy link
Member

nicoddemus commented Feb 8, 2022

basically get the test list and bisect the list with the falling test

OK thanks. That's what I do too basically. Never got around writing a plugin to automate doing that though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants