Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message for module level skip to include 'allow_module_level' #8906

Merged

Conversation

Naveen-Pratap
Copy link
Contributor

@Naveen-Pratap Naveen-Pratap commented Jul 14, 2021

Closes #8432

@nicoddemus
Copy link
Member

Thanks @Naveen-Pratap, we appreciate the contribution!

Took the liberty of tweaking the changelog message a bit. 👍

@nicoddemus nicoddemus changed the title Closes #8432 - Update error message for module level skip to include 'allow_module_level'. Update error message for module level skip to include 'allow_module_level' Jul 14, 2021
@nicoddemus nicoddemus enabled auto-merge (squash) July 14, 2021 12:28
@bluetech bluetech disabled auto-merge July 14, 2021 12:29
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting a few tweaks to the message.

src/_pytest/python.py Outdated Show resolved Hide resolved
@Naveen-Pratap Naveen-Pratap force-pushed the 8432-improve-handling-module-level-skip branch from b5ee3bf to 3035476 Compare July 14, 2021 13:42
@bluetech bluetech enabled auto-merge (squash) July 14, 2021 14:09
@bluetech bluetech merged commit febb978 into pytest-dev:main Jul 14, 2021
@Naveen-Pratap Naveen-Pratap deleted the 8432-improve-handling-module-level-skip branch July 14, 2021 14:59
RonnyPfannschmidt pushed a commit to RonnyPfannschmidt/pytest that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of skip for module level
3 participants