Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document autouse scope fixture priority #7260

Closed

Conversation

symonk
Copy link
Member

@symonk symonk commented May 25, 2020

Hi team, added some brief documentation explaining that autouse fixtures will be prioritized even when declared after non auto use fixtures in a test signature. closes #3404

@symonk
Copy link
Member Author

symonk commented May 25, 2020

Whoops seems the tests in there get actually ran, will address (on mobile right now)

@symonk symonk changed the title document autouse ordering when declared in test functions after non a… document autouse scope fixture priority May 26, 2020
@bluetech
Copy link
Member

Hi @symonk, isn't that sufficiently covered a few lines above? Specifically by this line:

a1: is a function-scoped autouse fixture: it will be instantiated before other fixtures within the same scope.

@symonk
Copy link
Member Author

symonk commented May 31, 2020

Thanks @bluetech I do see a1 now which outlines it, I will defer to you on this one. I think:

  • An example in code can help articulate the example nicely

But yep, that a1 line basically covers it

@bluetech
Copy link
Member

It's also mentioned in the paragraph introducing the existing example:

Autouse fixtures will be instantiated before explicitly used fixtures.

So I don't think another emphasis is needed.

@symonk
Copy link
Member Author

symonk commented May 31, 2020

Yes sir, closing 👍

@symonk symonk closed this May 31, 2020
@symonk symonk deleted the 3404-document-fixture-autouse-priority branch May 31, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't override an autouse fixture ordering
2 participants