Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Fix for Repr #7123

Closed
wants to merge 8 commits into from
Closed

Conversation

wilsonj24
Copy link

@wilsonj24 wilsonj24 commented Apr 25, 2020

Here is the link to the issue we had been working on. :#6985.

It is a proposed fix for the repr readability

@bluetech
Copy link
Member

Hi @wilsonj24,

Can you describe this PR a bit more? If it's a bug fix, what is the issue? If it's an improvement, in what way?

I suggest also to add tests to pytest's testing/ which cover all of the branches. That would help to demonstrate the changes as well.

@bluetech bluetech added the status: needs information reporter needs to provide more information; can be closed after 2 or more weeks of inactivity label Apr 25, 2020
@bluetech bluetech removed the status: needs information reporter needs to provide more information; can be closed after 2 or more weeks of inactivity label May 11, 2020
@bluetech
Copy link
Member

I did not see your edit (edits doesn't send notifications).

I think the next step is to add some tests to demonstrate what this changes, and notify the issue that you have a proposed fix.

@nicoddemus
Copy link
Member

Hi @wilsonj24,

First of all we would like to thank you for your time and effort on working on this, the pytest team deeply appreciates it.

We noticed it has been awhile since you have updated this PR, however. pytest is a high activity project, with many issues/PRs being opened daily, so it is hard for us maintainers to track which PRs are ready for merging, for review, or need more attention.

So for those reasons we think it is best to close the PR for now, but with the only intention to cleanup our queue, it is by no means a rejection of your changes. We still encourage you to re-open this PR (it is just a click of a button away) when you are ready to get back to it.

Again we appreciate your time for working on this, and hope you might get back to this at a later time!

Cheers!

@nicoddemus nicoddemus closed this Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants