Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed plurality issue #6505 #6730

Closed
wants to merge 5 commits into from
Closed

Fixed plurality issue #6505 #6730

wants to merge 5 commits into from

Conversation

ibarrezueta
Copy link

@ibarrezueta ibarrezueta commented Feb 13, 2020 •
edited by blueyed
Loading

@ibarrezueta ibarrezueta changed the title Fixed plurality issue Fixed plurality issue #6505 Feb 13, 2020
@blueyed
Copy link
Contributor

blueyed commented Feb 13, 2020

Thanks, but it should be kept singular/plural in user facing places - maybe you have mistaken the comment in #6505 (comment)?

A fix would look more like what was done in #6382.
See https://github.com/pytest-dev/pytest/pull/6382/files#diff-1284161c2c98c8aedd66545ff79a8af6R440-R442 specifically.

nicoddemus
nicoddemus requested changes Feb 14, 2020
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment •
edited by blueyed
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From #6730 (comment) (the comment above)

@Zac-HD
Copy link
Member

Zac-HD commented Jun 2, 2020

Closing this in favor of #6905 - thanks for your persistence @barrezuetai 🙂

@Zac-HD Zac-HD closed this Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ibarrezueta @blueyed @Zac-HD @nicoddemus