ci: Travis: Python 3.5.1 via Trusty #6440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Seems still needs work: |
|
@nicoddemus See my comment here: #6435 (comment) Should be fixed in hypothesis 5.1.3 which was released today. |
|
Cool, thanks for the link. 👍 |
|
Still fails with hypothesis 5.1.4: HypothesisWorks/hypothesis#2318 |
This was referenced Jan 11, 2020
gw2 then does not re-try the test (xdist issue?). I think we should run this only with a subset to cover enough of 3.5.{0,1} specific code. |
|
Should be good now. |
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 12, 2020
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 13, 2020
This covers special handling for typing. Ref: pytest-dev#6440.
Python 3.5.0 caused flaky failures before (pytest-dev#5795). This is pulled out of pytest-dev#6435, which adds code specific for Python < 3.5.2. It only runs a specific test, while collecting everything to get coverage of the version specific code around typing.
|
Would like to get this merged for #6435. |
nicoddemus
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.5.0 caused flaky failures before
(#5795), hopefully this is
more stable.
This is pulled out of #6435,
which adds code specific for Python < 3.5.2, and therefore it makes
sense to test it.