Remove deprecated license_file from setup.cfg #6375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nicoddemus
reviewed
Dec 27, 2019
| @@ -10,7 +10,6 @@ project_urls = | |||
| author = Holger Krekel, Bruno Oliveira, Ronny Pfannschmidt, Floris Bruynooghe, Brianna Laugher, Florian Bruhin and others | |||
|
|
|||
| license = MIT license | |||
| license_file = LICENSE | |||
There was a problem hiding this comment.
IIRC LICENSE is added automatically when found in newer setuptools, correct?
There was a problem hiding this comment.
It'll be automatically included in sdists by setuptools-scm (#6348 (comment)), and by wheel in wheels (https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file).
There was a problem hiding this comment.
Thanks for the confirmation! 👍
nicoddemus
approved these changes
Dec 27, 2019
blueyed
approved these changes
Jan 25, 2020
|
@hugovk |
Starting with wheel 0.32.0 (2018-09-29), the `license_file` option is deprecated. * https://wheel.readthedocs.io/en/stable/news.html The wheel will continue to include `LICENSE`, it is now included automatically: * https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file And `LICENSE` is still included in sdists thanks to setuptools-scm: * #6348 (comment)
|
Done, how's this? fe343a7 |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterbranch for bug fixes, documentation updates and trivial changes.featuresbranch for new features, improvements, and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
[trivial] Create a new changelog file in the
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.Add yourself to
AUTHORSin alphabetical order.Replaces and closes #6348.
Starting with wheel 0.32.0 (2018-09-29), the
license_fileoption is deprecated.The wheel will continue to include
LICENSE, it is now included automatically:And
LICENSEis still included in sdists thanks to setuptools-scm: