Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix typo in skipping.rst #5135

Merged
merged 1 commit into from
Apr 17, 2019
Merged

[Docs] Fix typo in skipping.rst #5135

merged 1 commit into from
Apr 17, 2019

Conversation

dougthor42
Copy link
Contributor

One of the pytest.mark.skipif blocks in docs/skipping.rst does not use the reason kwarg:

pytestmark = pytest.mark.skipif(sys.platform == "win32", "tests for linux only")

This causes an error during setup of test:

Failed: you need to specify reason=STRING when using booleans as conditions.

This PR fixes the typo by adding reason=.

-pytestmark = pytest.mark.skipif(sys.platform == "win32", "tests for linux only")
+pytestmark = pytest.mark.skipif(sys.platform == "win32", reason="tests for linux only")

Note: I did not make an associated Issue or Changelog entry for this PR because of how trivial it is. If that's needed, please let me know.

One of the `pytest.mark.skipif` blocks does not use the `reason` kwarg.
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #5135 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5135      +/-   ##
==========================================
+ Coverage   96.05%   96.06%   +<.01%     
==========================================
  Files         114      114              
  Lines       25784    25784              
  Branches     2550     2550              
==========================================
+ Hits        24768    24770       +2     
+ Misses        705      704       -1     
+ Partials      311      310       -1
Impacted Files Coverage Δ
testing/acceptance_test.py 98.03% <0%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eac473...0e651d7. Read the comment docs.

@nicoddemus nicoddemus merged commit 008d043 into pytest-dev:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants