Update deprecations.rst now that we have removed a few features #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
changed the title
* yield tests * compat properties * pytest_namespace All merciless cut down by Ronny :'(
nicoddemus
force-pushed
the
update-deprecations-docs
branch
from
ea571b2 to
5d2e237
Compare
|
good catch - well done, i totally forgot about this one ^^ |
RonnyPfannschmidt
approved these changes
Nov 22, 2018
asottile
approved these changes
Nov 22, 2018
nicoddemus
changed the title
|
Duh we did not yet removed |
Codecov Report
@@ Coverage Diff @@
## features #4446 +/- ##
============================================
+ Coverage 95.81% 95.85% +0.04%
============================================
Files 111 111
Lines 25038 25367 +329
Branches 2463 2515 +52
============================================
+ Hits 23989 24315 +326
- Misses 738 750 +12
+ Partials 311 302 -9
Continue to review full report at Codecov.
|
nicoddemus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized we forgot to do it in the same PRs when the features were removed. 😁
All mercilessly cut down by Ronny 😢
I see the GitHub diff is weird, but I basically moved the removed features to under the "Removed features" section and changed the "deprecated in X" line to "removed in X".