Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Fixturetest examples - move test contents to use example scripts for contents #3636

Merged

Conversation

RonnyPfannschmidt
Copy link
Member

this is a initial move of various things to example scripts as well as a removal of formatting strings to test files

the main benefit of having the actual test examples in text files is that we can run them directly and debug pytest directly

it also eases adding extracted examples of breakages to the testsuite, just copy in a folder an write a minimal testcase just taking and running it

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 92.665% when pulling 0fd86ec on RonnyPfannschmidt:fixturetest-examples into 8680dfc on pytest-dev:features.

@RonnyPfannschmidt RonnyPfannschmidt changed the title [RFC][WIP] Fixturetest examples - move test contents to use example scripts for contents [RFC] Fixturetest examples - move test contents to use example scripts for contents Jul 4, 2018
@RonnyPfannschmidt
Copy link
Member Author

its a good start as is, i dont want to work on more until its merged

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @RonnyPfannschmidt! (Sorry about the delay)

@nicoddemus nicoddemus merged commit f6ceedd into pytest-dev:features Jul 12, 2018
@nicoddemus nicoddemus mentioned this pull request Jul 12, 2018
@RonnyPfannschmidt RonnyPfannschmidt deleted the fixturetest-examples branch August 2, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants