Add messages property to caplog fixture.
#3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
approved these changes
Jun 15, 2018
nicoddemus
reviewed
Jun 15, 2018
| @@ -270,6 +270,22 @@ def record_tuples(self): | |||
| """ | |||
| return [(r.name, r.levelno, r.getMessage()) for r in self.records] | |||
|
|
|||
| @property | |||
| def messages(self): | |||
| """Returns a list of format-interpolated log messages. | |||
nicoddemus
reviewed
Jun 15, 2018
| caplog.set_level(logging.INFO) | ||
| logger.info("boo %s", "arg") | ||
| logger.info("bar %s\nbaz %s", "arg1", "arg2") | ||
| assert "boo arg" == caplog.messages[0] |
There was a problem hiding this comment.
We usually prefer to invert the order of the operands, but that's OK.
nicoddemus
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for issue #3579 per @nicoddemus suggestion.
I added the
versionaddedmarker for 3.7, assuming that it would not be in before that; I can correct that if needed.It passes all the Travis checks for me except sending to coveralls, presumably because I don't have an account setup with coveralls.
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.featuresbranch for new features and removals/deprecations.AUTHORSin alphabetical order;