Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ValueError to io.UnsupportedOperation in capture.py. Resolves … #2311

Closed

Conversation

metasyn
Copy link

@metasyn metasyn commented Mar 14, 2017

…issue #2276

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Target: for bug or doc fixes, target master; for new features, target features;

Unless your change is trivial documentation fix (e.g., a typo or reword of a small section) please:

  • Make sure to include one or more tests for your change;
  • Add yourself to AUTHORS;
  • Add a new entry to CHANGELOG.rst

For such a simple change, I only modified an existing test.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0008%) to 92.711% when pulling 6c393d0 on metasyn:DontReadFromInput-exceptions into 5e52a4d on pytest-dev:master.

@nicoddemus
Copy link
Member

Looks great, many thanks!

I took the liberty of rebasing your commits on the new master and tweaking the CHANGLOG a bit in #2313, so I'm closing this in favor of the new PR. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants