Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify travis.yml with tox environment variables #2264

Merged
merged 1 commit into from
Feb 19, 2017
Merged

Simplify travis.yml with tox environment variables #2264

merged 1 commit into from
Feb 19, 2017

Conversation

asottile
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.709% when pulling 5fd010c on asottile:simplify_travis into 21a09f0 on pytest-dev:master.

flub
flub approved these changes Feb 19, 2017
View reviewed changes
Copy link
Member

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kind of -0 on this in that explicit could be argued to be better then implicit. But I don't mind if we want to merge this.

@asottile
Copy link
Member Author

Personally I think TOXENV is pretty explicitly for tox. Understandable if you disagree.

Note that this is the documented interface to tox: http://tox.readthedocs.io/en/latest/config.html#confval-envlist=CSV

@nicoddemus
Copy link
Member

Thanks @asottile, I think this is OK and is also how AppVeyor is configured. 👍

@nicoddemus nicoddemus merged commit 6680cb9 into pytest-dev:master Feb 19, 2017
@asottile asottile deleted the simplify_travis branch February 28, 2017 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@flub flub flub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asottile @coveralls @nicoddemus @flub