Fix pytester internal plugin to work correctly with latest versions of zope.interface #2211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a little hack on
pytester
that deletes modules fromsys.modules
that were imported during inline runs and it included a little nugget that preventedzope.interface
from being deleted; apparentlyzope.interface
keeps some internal state that can't just be deleted fromsys.modules
.I guess at some point
zope.interface
was split into internal modules and the condition no longer had any effect. causing things to blow up spectacularly. 🔥At first glance this seems like an internal testing issue and I wasn't going to add a
CHANGELOG
entry, but then realized thatpytester
is part our public API so it warrants an entry.Fix #1989