Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytester internal plugin to work correctly with latest versions of zope.interface #2211

Merged
merged 2 commits into from
Jan 20, 2017

Conversation

nicoddemus
Copy link
Member

There's a little hack on pytester that deletes modules from sys.modules that were imported during inline runs and it included a little nugget that prevented zope.interface from being deleted; apparently zope.interface keeps some internal state that can't just be deleted from sys.modules.

I guess at some point zope.interface was split into internal modules and the condition no longer had any effect. causing things to blow up spectacularly. 🔥

At first glance this seems like an internal testing issue and I wasn't going to add a CHANGELOG entry, but then realized that pytester is part our public API so it warrants an entry.

Fix #1989

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.819% when pulling 2574da8 on nicoddemus:trial-envs into d15724f on pytest-dev:master.

@RonnyPfannschmidt
Copy link
Member

@nicoddemus please rebase, also FML changelogs (i want the issue wrt changelogs gone)

@nicoddemus
Copy link
Member Author

Oh my! Just used the new "Resolve Conflicts" button on the UI, very cool. Fixing CHANGELOG conflicts is now a breeze! 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.831% when pulling 3766060 on nicoddemus:trial-envs into e0c48b4 on pytest-dev:master.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 1a2d638 into pytest-dev:master Jan 20, 2017
@nicoddemus nicoddemus deleted the trial-envs branch January 20, 2017 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants