Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a wrapper script to bypass check-manifest if not under git #2053

Merged
merged 1 commit into from
Nov 12, 2016

Conversation

nicoddemus
Copy link
Member

Wrapper script is necessary because we are not under version when testing the package directly using devpi test.

Related to comment in #2051

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.79% when pulling c0b1ceb on nicoddemus:check-manifest-script into 5717c71 on pytest-dev:master.

@nicoddemus
Copy link
Member Author

Hehehe the failure:

linting runtests: commands[0] | /home/travis/build/pytest-dev/pytest/.tox/linting/bin/python scripts/check-manifest.py
lists of files in version control and sdist do not match!
missing from sdist:
  scripts
  scripts/check-manifest.py
suggested MANIFEST.in rules:
  recursive-include scripts *.py

Oh the irony! 😆

@nicoddemus nicoddemus force-pushed the check-manifest-script branch from c0b1ceb to d4b8f2c Compare November 11, 2016 20:04
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.79% when pulling d4b8f2c on nicoddemus:check-manifest-script into 5717c71 on pytest-dev:master.

@nicoddemus nicoddemus force-pushed the check-manifest-script branch from d4b8f2c to 351395b Compare November 12, 2016 13:40
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.79% when pulling 351395b on nicoddemus:check-manifest-script into 71b6833 on pytest-dev:master.

@nicoddemus
Copy link
Member Author

Merging as this is a minor update.

@nicoddemus nicoddemus merged commit 5185f2a into pytest-dev:master Nov 12, 2016
@nicoddemus nicoddemus deleted the check-manifest-script branch November 12, 2016 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants