Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to PDF docs #1919

Merged
merged 1 commit into from
Sep 7, 2016
Merged

Fix link to PDF docs #1919

merged 1 commit into from
Sep 7, 2016

Conversation

The-Compiler
Copy link
Member

Fixes #1917

@@ -6,6 +6,6 @@
<li><a href="https://github.com/pytest-dev/pytest/">pytest @ GitHub</a></li>
<li><a href="http://plugincompat.herokuapp.com/">3rd party plugins</a></li>
<li><a href="https://github.com/pytest-dev/pytest/issues">Issue Tracker</a></li>
<li><a href="http://pytest.org/latest/pytest.pdf">PDF Documentation</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps the link should show to the exact own release on rtd
else older releases will point to the up2date pdf

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how that'd be possible without us adjusting three PDF links with every release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RonnyPfannschmidt I agree that would be ideal, but as @The-Compiler said I also don't see how to do that in any automated manner.

FWIW this link was always pointing to the "latest" before moving to RTD, so unless we have a suggestion on how to easily update this link automatically I would rather have the broken link fixed now than later. 😁

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.078% when pulling 8e67dd1 on The-Compiler:pdf into 99efc28 on pytest-dev:master.

@RonnyPfannschmidt
Copy link
Member

Let's make an issue and ask rtd?

@nicoddemus
Copy link
Member

Sure sure, if they have a solution it would be most welcome! 😁

@The-Compiler
Copy link
Member Author

So can we merge this, since that is unrelated to this PR?

@nicoddemus nicoddemus merged commit 51378ab into pytest-dev:master Sep 7, 2016
@nicoddemus
Copy link
Member

Thanks @The-Compiler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants