Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the default plugin "pdb" into "debugging" #1663

Merged
merged 2 commits into from
Jun 25, 2016

Conversation

aostr
Copy link

@aostr aostr commented Jun 25, 2016

The pdb module name conflicts with the python debugger module.

aostr added 2 commits June 25, 2016 12:09
Combining multiple imports the "import pdb" imports the pytest module
as opposed to the python debugger.
@coveralls
Copy link

coveralls commented Jun 25, 2016

Coverage Status

Coverage remained the same at 92.233% when pulling 9a5224e on aostr:master into 0c63762 on pytest-dev:master.

@RonnyPfannschmidt
Copy link
Member

i wonder what problem that solves (this has been working since years, and its a name change)

@nicoddemus
Copy link
Member

Problem is that depending where the current directory is, import pdb might import _pytest.pdb instead of builtin pdb. I think this should go in.

@aostr the only thing missing is a changelog entry, because the internal plugin was renamed to debugging as well (although I doubt anybody depends on this).

@RonnyPfannschmidt
Copy link
Member

i did a quick github search and it matched only in copies/forks of pytest

@RonnyPfannschmidt
Copy link
Member

i discussed the need of this with @nicoddemus and @blueyed - arrived at the conclusion that its a good idea to rename to support debugging while using the common pdb shortcuts 👍

@nicoddemus nicoddemus merged commit c519b95 into pytest-dev:master Jun 25, 2016
@nicoddemus
Copy link
Member

Thanks @aostr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants