Fix #1290: Py3.5's @ operator/assertion rewriting. #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @pytest.mark.skipif("sys.version_info < (3,5)") | ||
| def test_at_operator_issue1290(self): | ||
| def f(): | ||
| class Matrix: |
There was a problem hiding this comment.
I guess you will have to use eval or exec here to avoid syntax errors in Python versions < 3.5. 😁
|
Thanks a lot @tomviner! 😄 |
tomviner
force-pushed
the
issue1290-at-operator
branch
from
35d6bbf to
552cfa7
Compare
|
@nicoddemus I've had another go with |
tomviner
force-pushed
the
issue1290-at-operator
branch
from
552cfa7 to
f63b706
Compare
|
|
||
| def test_multmat_operator(): | ||
| assert Matrix(2) @ Matrix(3) == 42""") | ||
| testdir.runpytest().assert_outcomes(failed=1) |
There was a problem hiding this comment.
Hmm doesn't this test also pass if you take out your fix in rewrite.py? Wouldn't be better to make the the inner test pass?
tomviner
force-pushed
the
issue1290-at-operator
branch
from
f63b706 to
7d10701
Compare
|
@nicoddemus good point, I got confused in thinking that a failing inner test was required to engage the rewrite code, but that's obviously not true as shown in @Shinkenjoe's original test case. Changed. |
|
Excellent, thanks! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1290
Support
ast.MatMultwhen it's present. And add a test that runs on Python 3.5+. See PEP 465 -- A dedicated infix operator for matrix multiplication