-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert the unintended change in tests reordering from #11220 #12542
Revert the unintended change in tests reordering from #11220 #12542
Conversation
5d038d9
to
859979f
Compare
…nge-in-reordering-from-pr-11220' into fix-unnoticed-change-in-reordering-from-pr-11220
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for addressing this
@bluetech please give it a quick check as well, else i'd like to get this in soon @sadra-barikbin do we need to backport this? |
To 8.2.2 and its earlier versions back to 8.0.1 or just 8.2.2? |
We usually only do patch releases for the latest stable branch, i.e. 8.2. |
It would be nice to get @bluetech's review here too before we merge this. |
in case its not possible to get ran's feedback this by Sunday, lets merge, i believe its good to go and we shouldn't block for too long just because hes busy |
Co-authored-by: Bruno Oliveira <[email protected]>
sorry for the delay and thanks for the patience |
Thanks @RonnyPfannschmidt. Given this is marked as bugfix, should we backport it? |
As bluetech removed the back port label I believe we ought not, else he can revise |
Ahh I missed that, sorry. We should not backport then. 👍 |
In #11220, an unintended change in reordering was introduced by changing the way indices were assigned to direct params. This PR reverts that change and reduces #11220 changes to just refactors.
After this PR we could safely decide on the solutions discussed in #12008, i.e. #12082 or the one initially introduced in #11220 .
Fixes #12008
@bluetech @RonnyPfannschmidt