importlib: set children as attribute of parent modules #12208
Merged
Commits on Apr 20, 2024
-
importlib: set module as attribute in its parent module
This needs to be done manually, not being done as part of the import mechanism: https://github.com/python/cpython/blob/73906d5c908c1e0b73c5436faeff7d93698fc074/Lib/importlib/_bootstrap.py#L1335-L1342 Fix pytest-dev#12194
-
importlib: _import_module_using_spec also imports parent modules
According to the Python import implementation: https://github.com/python/cpython/blob/73906d5c908c1e0b73c5436faeff7d93698fc074/Lib/importlib/_bootstrap.py#L1308-L1311 When we import a module we should also import its parents, and set the child as attribute of its parent.
-
Use _import_module_using_spec to import parent modules
Seems this is the right thing to do, as we will then also consider the parent modules for rewriting.
-
Seems we need to insert missing modules when the modules are not part of a package or namespace package.
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.