Avoid ast deprecation warnings on Python 3.12 #10981
Conversation
There was a problem hiding this comment.
Looks good to me!
Alternatively, we might just wait for the Python 3.7 end of life in June, and then refactor to use the new nodes only since we'll presumably want to do that eventually.
|
Wondering if early drop of 3.7 makes sense We could probably anhilate quite some support code |
I would rather not having to "justify" that decision to the community... whenever we drop a version we get some flak for it, I think we would get even more flak by just dropping a Python version which is still supported. I think we can wait until it is officially dropped before going forward with pytest itself dropping it. |
|
It's also against policy, per https://docs.pytest.org/en/stable/backwards-compatibility.html#python-version-support (though it might be nice to link from that page to https://devguide.python.org/versions/ ...) |
|
Hi, the Python 3.12 beta is now out! https://blog.python.org/2023/05/python-3120-beta-1-released.html |
bluetech
force-pushed
the
py312-ast-deprecations
branch
from
9fb0fce to
bdb453d
Compare
|
Tried it but still not available in github actions. Seems like we need to wait until it shows up here: https://github.com/actions/python-versions/releases |
|
I'm going to fold this PR into #10894 to make things easier to test and backport later. |
Fix #10977.
Marking as draft until we can verify the fix on next py312 alpha/beta release.