-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable PYTHONWARNDEFAULTENCODING=1
and fix violations
#10935
Conversation
PYTHONWARNDEFAULTENCODING=1
and fix violations
3c6606e
to
fa9c498
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, I didn't think anyone would have the endurance to do this one :)
I suggest merging this quickly to avoid conflicts and regressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, thanks @Zac-HD and @nondescryptid! I noticed a couple of small things, but I agree we should aim to merge this quickly (and I'm looking forward to turning this warning on for my own project finally!).
8841734
to
f6b995e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! IMHO this deserves its own changelog entry to make downstream projects aware that they can now use this, but that could be done in a follow up PR too.
Oh my goodness. @The-Compiler So sorry about not responding earlier to your request for changes. I didn't receive notifications for this and only realised this had been merged when I was looking through my account's commit history and wondered why I had a commit to pytest. Massive thanks to you, @bluetech and @Zac-HD! |
All good, no worries! We got it all merged, and it still was a good starting point :) |
Updated attempt to check encoding warnings as in #10328, as dependencies have been updated in the past 6 months.
(Zac edit: now also fixes #7781)