-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: revisit folding skipped tests in summary #9876
Comments
The folding was introduced for sensible reporting even when there are hundreds of skips for reasons AFAIK those numbers tend to be hit with skips often enough to warrant it, i haven't observed similar usage for xfail /xpass which is used in very different use cases Im explicitly in favour of the difference here |
Hmm, hundreds of skips due to parameterization I assume? I think I would personally prefer the test class::function name on its own instead of a line number, as I'd assume that has to be just as foldable as the line number. |
This controlls how the skipped tests are display in the short summary. - yes (default): keeps the current behavior that folds the skipped tests together - no: each skipped test is on its own line, display as any other status Resolves: pytest-dev#9876 Signed-off-by: Pavel Březina <[email protected]>
This controlls how the skipped tests are display in the short summary. - yes (default): keeps the current behavior that folds the skipped tests together - no: each skipped test is on its own line, display as any other status Resolves: pytest-dev#9876 Signed-off-by: Pavel Březina <[email protected]>
This controlls how the skipped tests are display in the short summary. - yes (default): keeps the current behavior that folds the skipped tests together - no: each skipped test is on its own line, display as any other status Resolves: pytest-dev#9876 Signed-off-by: Pavel Březina <[email protected]>
This controlls how the skipped tests are display in the short summary. - yes (default): keeps the current behavior that folds the skipped tests together - no: each skipped test is on its own line, display as any other status Resolves: pytest-dev#9876 Signed-off-by: Pavel Březina <[email protected]>
Currently we "fold" skipped tests in the summary:
They are the only entries which don't show the node id, showing the file name and line number instead, and also try to fold/accumulate the summaries which come from the same skip marker/reason.
I tracked it down to prokaktus@3795b08, which introduced the
-r
option.I wonder if this inconsistency is still worth having? Personally I would prefer the SKIPPED message to look the same as XFAIL/XPASS, and show up as once for each skipped test, instead of having them folded.
I notice there's a comment in the current code too regarding markers:
pytest/src/_pytest/terminal.py
Lines 1319 to 1321 in 28e8c85
Perhaps @RonnyPfannschmidt can remark on that comment.
The text was updated successfully, but these errors were encountered: