Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] should not check (all) links #6612

Closed
blueyed opened this issue Jan 29, 2020 · 2 comments
Closed

[release] should not check (all) links #6612

blueyed opened this issue Jan 29, 2020 · 2 comments
Labels
type: infrastructure improvement to development/releases/CI structure

Comments

@blueyed
Copy link
Contributor

blueyed commented Jan 29, 2020

tox -e release -- … triggers the link checking, which is very slow.

This should only be done on demand I think.

There's an option to skip it: https://github.com/blueyed/pytest/blob/059bf16d09dde7720876fae67a1f096b401137ac/scripts/release.py#L118

@blueyed blueyed changed the title [release]: should not check links [release] should not check (all) links Jan 29, 2020
@Zac-HD Zac-HD added the type: infrastructure improvement to development/releases/CI structure label Jan 29, 2020
@nicoddemus
Copy link
Member

I was a bit concerned about this as well, but after making the release a few times I don't really seem to notice (takes less than 3 minutes or so).

@The-Compiler
Copy link
Member

FWIW we've already had this discussion in #1722.

If only doing it on demand, I bet nobody will ever do it 😉 Like @nicoddemus said, if it's not a problem when releasing in practice, I don't see why it should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: infrastructure improvement to development/releases/CI structure
Projects
None yet
Development

No branches or pull requests

4 participants