Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_argcomplete should not call python directly #5872

Closed
scarabeusiv opened this issue Sep 23, 2019 · 1 comment · Fixed by #5873
Closed

test_argcomplete should not call python directly #5872

scarabeusiv opened this issue Sep 23, 2019 · 1 comment · Fixed by #5873

Comments

@scarabeusiv
Copy link
Contributor

on the most distros it points to py2 or it is not really deterministic.

The call itself is following:
fp.write('COMP_WORDBREAKS="$COMP_WORDBREAKS" python -m pytest 8>&1 9>&2')

I suppose it should use sys.executable or at least python3 as the py2 is not compatible anyway.
@asottile
Copy link
Member

sys.executable would be best, would you like to submit a patch? thanks!

(it mostly works right now because it runs in a virtualenv)

@scarabeusiv scarabeusiv changed the title test_argcomplete should not call python directy test_argcomplete should not call python directly Sep 23, 2019
@scarabeusiv scarabeusiv mentioned this issue Sep 23, 2019
Merged
nicoddemus added a commit that referenced this issue Sep 23, 2019
@nicoddemus
Do not call python directly but use sys.executable. Fixes #5872 (#5873)
7c64d5d 
Do not call python directly but use sys.executable. Fixes #5872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not call python directly but use sys.executable. Fixes #5872
2 participants
@scarabeusiv @asottile