Support -r w and remove --disable-warnings argument

[blueyed]

It was added in e04d9ff by @aostr, and its only purpose is to remove the "w" in reportopts.

In #1668 (comment) it is mentioned that this was discussed with @hpk42.

The main intention here appears to be to enable them by default.

I suggest adding support for -w in reportchars instead.

This would also allow for something like a-s to have everything, without "skipped" easily.

(came here because I want to add A also to also include pP passed ones)

[nicoddemus]

I like to be able to pass -w in front of a report char in order to hide it from the output.

To give some more context, I believe this option was added as a quick way to disable warnings because at that time we have decided to show internal warnings by default, and thought people would get annoyed (and people did). Since then a lot has changed, with us dropping the internal warnings system and showing all warnings by default (and more people got annoyed too hehehe).

But it doesn't seem necessary to actually remove the option, does it? Or is just a matter to cleanup what we believe is mostly an unused option?

[blueyed]

But it doesn't seem necessary to actually remove the option, does it? Or is just a matter to cleanup what we believe is mostly an unused option?

Yes, for cleanup.

I like to be able to pass -w in front of a report char in order to hide it from the output.

Cool.

[nicoddemus]

Yes, for cleanup.

I see, thanks. 👍

I agree, definitely sounds good. We just have to follow the normal deprecation procedure: emit warnings and only remove it effectively in 5.0. 😁