Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Location for Where to Provide Feedback for --import-mode=importlib #10003

Closed
adam-grant-hendry opened this issue May 30, 2022 · 2 comments · Fixed by #10007
Closed

Add Location for Where to Provide Feedback for --import-mode=importlib #10003

adam-grant-hendry opened this issue May 30, 2022 · 2 comments · Fixed by #10007

Comments

@adam-grant-hendry
Copy link

What's the problem this feature will solve?

Reading here, it says:

We intend to make importlib the default in future releases, depending on feedback.

However, I don't know where to provide feedback.

Describe the solution you'd like

Please add to the docs a location where users should provide feedback.

Alternative Solutions

N/A

Additional context

I've used --import-mode=importlib successfully and I think it should become the new default!

@adam-grant-hendry
Copy link
Author

Similarly, the note here says:

The new --import-mode=importlib (see Import modes) doesn’t have any of the drawbacks above because sys.path is not changed when importing test modules, so users that run into this issue are strongly encouraged to try it and report if the new option works well for them.

but doesn't state where to provide feedback.

nicoddemus added a commit to nicoddemus/pytest that referenced this issue May 31, 2022
It is clear at this point that changing the default would break a lot of suites, and is not a clear win in all cases anyway.

Close pytest-dev#10003
nicoddemus added a commit to nicoddemus/pytest that referenced this issue May 31, 2022
It is clear at this point that changing the default would break a lot of suites, and is not a clear win in all cases anyway.

Close pytest-dev#10003
@nicoddemus
Copy link
Member

The issue is in #7245, however at this point it is clear that we should not change the default, as importlib has its own set of drawbacks and changing the default would severely impact a lot of test suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants