Skip to content

Commit

Permalink
Merge pull request #5811 from blueyed/fulltrace-pytest-raises
Browse files Browse the repository at this point in the history
Handle --fulltrace with pytest.raises
  • Loading branch information
blueyed authored Sep 14, 2019
2 parents 9422e10 + f832ac3 commit 702acdb
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
1 change: 1 addition & 0 deletions changelog/5811.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Handle ``--fulltrace`` correctly with ``pytest.raises``.
4 changes: 1 addition & 3 deletions src/_pytest/nodes.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,15 +245,13 @@ def _repr_failure_py(self, excinfo, style=None):
fm = self.session._fixturemanager
if excinfo.errisinstance(fm.FixtureLookupError):
return excinfo.value.formatrepr()
tbfilter = True
if self.config.getoption("fulltrace", False):
style = "long"
else:
tb = _pytest._code.Traceback([excinfo.traceback[-1]])
self._prunetraceback(excinfo)
if len(excinfo.traceback) == 0:
excinfo.traceback = tb
tbfilter = False # prunetraceback already does it
if style == "auto":
style = "long"
# XXX should excinfo.getrepr record all data and toterminal() process it?
Expand All @@ -279,7 +277,7 @@ def _repr_failure_py(self, excinfo, style=None):
abspath=abspath,
showlocals=self.config.getoption("showlocals", False),
style=style,
tbfilter=tbfilter,
tbfilter=False, # pruned already, or in --fulltrace mode.
truncate_locals=truncate_locals,
)

Expand Down
7 changes: 7 additions & 0 deletions testing/code/test_excinfo.py
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,13 @@ def test_division_zero():
result = testdir.runpytest()
assert result.ret != 0
result.stdout.fnmatch_lines(["*AssertionError*Pattern*[123]*not found*"])
assert "__tracebackhide__ = True" not in result.stdout.str()

result = testdir.runpytest("--fulltrace")
assert result.ret != 0
result.stdout.fnmatch_lines(
["*__tracebackhide__ = True*", "*AssertionError*Pattern*[123]*not found*"]
)


class TestFormattedExcinfo:
Expand Down

0 comments on commit 702acdb

Please sign in to comment.