Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate rsync support #828

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Conversation

nicoddemus
Copy link
Member

Fix #825

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus
Copy link
Member Author

Good catch, done, thanks!

@nicoddemus nicoddemus merged commit 31e80c8 into pytest-dev:master Oct 24, 2022
@nicoddemus nicoddemus deleted the deprecate-rsync-825 branch October 24, 2022 16:03
@henryiii
Copy link

henryiii commented Oct 26, 2022

In pypa/build#527, I'm getting:

py39 run-test: commands[0] | pytest -ra --cov --cov-config pyproject.toml --cov-report=html:/home/runner/work/build/build/.tox/py39/htmlcov --cov-context=test --cov-report=xml:/home/runner/work/build/build/.tox/coverage.py39.xml -n auto
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/home/runner/work/build/build/.tox/py39/lib/python3.9/site-packages/_pytest/main.py", line 266, in wrap_session
INTERNALERROR>     config._do_configure()
INTERNALERROR>   File "/home/runner/work/build/build/.tox/py39/lib/python3.9/site-packages/_pytest/config/__init__.py", line 1037, in _do_configure
INTERNALERROR>     self.hook.pytest_configure.call_historic(kwargs=dict(config=self))
INTERNALERROR>   File "/home/runner/work/build/build/.tox/py39/lib/python3.9/site-packages/pluggy/_hooks.py", line 277, in call_historic
INTERNALERROR>     res = self._hookexec(self.name, self.get_hookimpls(), kwargs, False)
INTERNALERROR>   File "/home/runner/work/build/build/.tox/py39/lib/python3.9/site-packages/pluggy/_manager.py", line 80, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>   File "/home/runner/work/build/build/.tox/py39/lib/python3.9/site-packages/pluggy/_callers.py", line 60, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/home/runner/work/build/build/.tox/py39/lib/python3.9/site-packages/pluggy/_result.py", line 60, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/home/runner/work/build/build/.tox/py39/lib/python3.9/site-packages/pluggy/_callers.py", line 39, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/home/runner/work/build/build/.tox/py39/lib/python3.9/site-packages/xdist/plugin.py", line 214, in pytest_configure
INTERNALERROR>     config.issue_config_time_warning(warning, 2)
INTERNALERROR>   File "/home/runner/work/build/build/.tox/py39/lib/python3.9/site-packages/_pytest/config/__init__.py", line 1394, in issue_config_time_warning
INTERNALERROR>     warnings.warn(warning, stacklevel=stacklevel)
INTERNALERROR> DeprecationWarning: The --rsyncdir command line argument and rsyncdirs config variable are deprecated.
INTERNALERROR> The rsync feature will be removed in pytest-xdist 4.0.
ERROR: InvocationError for command /home/runner/work/build/build/.tox/py39/bin/pytest -ra --cov --cov-config pyproject.toml --cov-report=html:/home/runner/work/build/build/.tox/py39/htmlcov --cov-context=test --cov-report=xml:/home/runner/work/build/build/.tox/coverage.py39.xml -n auto (exited with code 3)

Build doesn't touch rsyncdir, so is this leaking in from coverage or some other plugin? (Specifically, is there a way to figure out what's setting this configuration value and triggering the INTERNALERROR). The traceback just goes to pluggy which IIRC is pytest's tool for running plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate rsync support
3 participants