Implement __eq__ for File objects

[mdelapenya]

Hello, I'm getting this error while checking the linked_to of a valid symlink.

        def test_paths_are_symliks(host):
            myPath = host.file("/mnt/jenkins/workspace")
            myLink = host.file("/home/ubuntu/workspace")
            assert myPath.exists
            assert myLink.exists
            assert myLink.is_symlink
            assert myLink.linked_to == myPath

    E           AssertionError: assert '/mnt/jenkins/workspace' == <file /mnt/jenkins/workspace>
    E            +  where '/mnt/jenkins/workspace' = <file /home/ubuntu/workspace>.linked_to

Is the last assertion returning a file object instead of the string representation of its path?

Thanks!

PS: close this issue if you consider is not a bug

[philpep]

HI, that's because myPath is an object.

You should either assert myLink.linked_to == "/mnt/jenkins/workspace" or assert myLink.linked_to == myPath.path.

I think we could have a __eq__() method on file objects for such case, so let's keep this ticket open.

[mdelapenya]

I totally see it now... I don't know why I did not see it before: I was just putting the eyes on the wrong side of the equation, when the problem was at the other 😄

It works now, thanks!