Add reusable workflow #484
Conversation
BeyondEvil
force-pushed
the
add-reusable-workflow
branch
from
04fee8c to
c8d8e9d
Compare
| - name: QUnit Tests | ||
| run: npm test | ||
|
|
||
| linting: |
There was a problem hiding this comment.
coudl thisone be migrated to precommit.ci?
There was a problem hiding this comment.
Not sure what you mean @RonnyPfannschmidt ?
It is run by pre-commit: https://github.com/pytest-dev/pytest-html/blob/master/tox.ini#L22
There was a problem hiding this comment.
We have been enabling this for many pytest plugins, including pytest itself, and are very happy with the results.
There was a problem hiding this comment.
We have been enabling this for many pytest plugins, including pytest itself, and are very happy with the results.
Oh, nice!
I'll follow up this PR with one to migrate it then. 👍
There was a problem hiding this comment.
We have been enabling this for many pytest plugins, including pytest itself, and are very happy with the results.
How exactly do I migrate?
According to pre-commit.ci docs - nothing is needed except the config file (which exists) and I couldn't find anything in the pytest repo to hint at how to do it either? @nicoddemus
There was a problem hiding this comment.
We have been enabling this for many pytest plugins, including pytest itself, and are very happy with the results.
Ah, I think I figured it out.
There was a problem hiding this comment.
You don't need to add anything to the repository, we just need to enable it in the project settings. Is that what you did?
There was a problem hiding this comment.
You don't need to add anything to the repository, we just need to enable it in the project settings. Is that what you did?
Yep, that's what I did. :)
* remove phantomjs dependency (#424) * properly classify all npm dependencies (#425) * Move the changelog to read the docs (#423) * split plugin.py into smaller files (#427) * Implement the visible URL query parameter to control visibility of test results on page load. (#433) * enable control of test result visability via query params * Allow for redacting of environment table values (#431) * Disable Codecov (#480) * Disable Codecov * Disable pypy3 on mac * Add Tests.yml reusable workflow (#484) * Use the tests reusable workflow (#486) * Migrate to precommit.ci (#487) * Separate Nightly workflow (#488) Co-authored-by: Gleb Nikonorov <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* remove phantomjs dependency (pytest-dev#424) * properly classify all npm dependencies (pytest-dev#425) * Move the changelog to read the docs (pytest-dev#423) * split plugin.py into smaller files (pytest-dev#427) * Implement the visible URL query parameter to control visibility of test results on page load. (pytest-dev#433) * enable control of test result visability via query params * Allow for redacting of environment table values (pytest-dev#431) * Disable Codecov (pytest-dev#480) * Disable Codecov * Disable pypy3 on mac * Add Tests.yml reusable workflow (pytest-dev#484) * Use the tests reusable workflow (pytest-dev#486) * Migrate to precommit.ci (pytest-dev#487) * Separate Nightly workflow (pytest-dev#488) Co-authored-by: Gleb Nikonorov <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
GitHub Actions recently introduced reusable workflows.
I want to use that functionality to split out the different workflows to make them a little bit more focused and easier to understand.
This is a prepatory step to enable that.