Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multiprocess finalizer and improve subprocess docs #265

Merged
merged 34 commits into from
Mar 9, 2019
Merged

Remove multiprocess finalizer and improve subprocess docs #265

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
3160976
Stop using multiprocess finalizers. Better document workarounds for u…
ionelmc Feb 16, 2019
1210cdc
Rename file.
ionelmc Feb 16, 2019
0533855
Update docs/subprocess-support.rst
blueyed Feb 16, 2019
892f4e1
Update docs/subprocess-support.rst
blueyed Feb 16, 2019
b494c37
Update docs/subprocess-support.rst
blueyed Feb 16, 2019
5d49467
Remove the note about windows completely.
ionelmc Feb 16, 2019
1cb8ce6
Well ... bring back the finalizer, but make the cleanup reentrant.
ionelmc Feb 17, 2019
8014767
Remove this attribute and rely on pytest_cov.embed's internal storage…
ionelmc Feb 17, 2019
38c89a8
Ignore SIG_DFL (lil regression).
ionelmc Feb 17, 2019
5374581
Avoid doubly registering the signal handler (so the previous handler …
ionelmc Feb 17, 2019
710e4cc
Add missing global.
ionelmc Feb 17, 2019
8a2bfa8
Add a test for #250.
ionelmc Feb 17, 2019
4046fc2
Add a windows specific test.
ionelmc Feb 17, 2019
65d50cf
Some renaming to better reflect what is actually tested.
ionelmc Feb 17, 2019
49f55d6
Add few more multiprocessing tests and change some details for skips.
ionelmc Feb 17, 2019
b449d92
Skip a bunch of stuff on windows+pypy - it's broken, see https://gith…
ionelmc Feb 18, 2019
c32c158
Correct some assertions. Revert bogus change.
ionelmc Feb 18, 2019
ab9d7bc
Run this fewer times. Maybe travis too slow for such heavy test.
ionelmc Feb 18, 2019
cd0c4a4
Rework a bit the mp pool integration tests to generate a line of code…
ionelmc Feb 21, 2019
3d3b488
Some cleanup.
ionelmc Feb 21, 2019
2291d76
Skip this on windows/pypy (xdist broken).
ionelmc Feb 22, 2019
8f1b9e6
Extend assertion a bit.
ionelmc Feb 22, 2019
478152e
Change the docs again to reflect the current implementation.
ionelmc Feb 22, 2019
7aa50d9
Fix escaping.
ionelmc Feb 23, 2019
3709127
Use travis_wait (mainly for pypy which often times out).
ionelmc Feb 23, 2019
35f38f4
Use travispls instead - travis_wait is so broken ...
ionelmc Feb 23, 2019
bcdce59
Don't run pypy3 on Windows.
ionelmc Feb 23, 2019
c11fe04
Skip the terminate tests on PyPy and remove travispls (doesn't work o…
ionelmc Feb 23, 2019
103d1ef
Remove the automatic SIGTERM handler install from the afterfork
ionelmc Feb 25, 2019
66d8ade
Avoid having stray tracers around. This fixes an "AssertionError: Exp…
ionelmc Feb 25, 2019
65959fc
Avoid writing bogus data files from dead coverage tracers.
ionelmc Feb 25, 2019
fdc43ec
Allow COV_CORE_SOURCE to be empty (it'd be converted to None). Also u…
ionelmc Feb 25, 2019
7557f67
Fix cleanup leaving unusable state.
ionelmc Feb 25, 2019
42f0307
Always skip this on PyPy as it sometimes fail with `error: release un…
ionelmc Mar 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ environment:
- TOXENV: 'py27-t310-c45,py27-t40-c45,py27-t41-c45'
- TOXENV: 'py34-t310-c45,py34-t40-c45,py34-t41-c45'
- TOXENV: 'py35-t310-c45,py35-t40-c45,py35-t41-c45'
- TOXENV: 'pypy-t310-c45,pypy-t40-c45,pypy-t41-c45,pypy3-t310-c45,pypy3-t40-c45,pypy3-t41-c45'
- TOXENV: 'pypy-t310-c45,pypy-t40-c45,pypy-t41-c45'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be kept, but the problem appears to be that only pypy gets installed (unconditionally)?!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See pytest-dev/pytest@ec69514 for installing it only if needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't install pypy there at all - it's preinstalled. Either way, I don't want to bother with pypy3 yet on Windows (it's beta anyway, and xdist is broken on pypy windows, so why bother with extensive testing on such a platform).


init:
- ps: echo $env:TOXENV
Expand Down
2 changes: 1 addition & 1 deletion ci/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@

template_vars = {'tox_environments': tox_environments}
for py_ver in '27 34 35 py'.split():
template_vars['py%s_environments' % py_ver] = [x for x in tox_environments if x.startswith('py' + py_ver)]
template_vars['py%s_environments' % py_ver] = [x for x in tox_environments if x.startswith('py' + py_ver + '-')]

for name in os.listdir(join("ci", "templates")):
with open(join(base_path, name), "w") as fh:
Expand Down