FIX: SCN and SCCNN breaking after TopoNetX code change on the up laplacian

[ninamiolane]

…p laplacian on simplicial complexes yet

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[ffl096]

Thanks for the fix, this was still on my to-do! I'll merge once tests have completed :)

[ninamiolane]

@ffl096 Awesome! This PR is only a quick fix, the better fix would be to allow 'weights' to be passed for the up laplacian: is this on your todo?

[ffl096]

Weights are not implemented at all in TopoNetX yet. I think that would be a larger tasks that I don't have time to work on right now. If nobody else picks this up in let's say two weeks, I can take a look at it. Lets keep track of this in pyt-team/TopoNetX#245.

For context: Before pyt-team/TopoNetX#242, the weight parameter was just silently ignored. The laplacian matrix never was weighted.

[ninamiolane]

Goooot it! Yes, I was wondering why the up laplacian was the only neighborhood structure for which it was failing. Good idea to keep track of this.

[codecov]

Codecov Report

Patch coverage: 66.66% and project coverage change: -1.02% ⚠️

Comparison is base (1ece602) 97.29% compared to head (3805244) 96.27%.
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   97.29%   96.27%   -1.02%     
==========================================
  Files          57       56       -1     
  Lines        2070     2042      -28     
==========================================
- Hits         2014     1966      -48     
- Misses         56       76      +20     

Files Changed	Coverage Δ
topomodelx/base/message_passing.py	96.22% <ø> (ø)
topomodelx/nn/cell/can.py	89.28% <ø> (ø)
topomodelx/nn/cell/can_layer.py	100.00% <ø> (ø)
topomodelx/nn/cell/ccxn.py	100.00% <ø> (ø)
topomodelx/nn/cell/ccxn_layer.py	100.00% <ø> (ø)
topomodelx/nn/cell/cwn.py	100.00% <ø> (ø)
topomodelx/nn/cell/cwn_layer.py	100.00% <ø> (ø)
topomodelx/nn/hypergraph/allset.py	100.00% <ø> (ø)
topomodelx/nn/hypergraph/allset_layer.py	88.88% <ø> (ø)
topomodelx/nn/hypergraph/allset_transformer.py	100.00% <ø> (ø)
... and 31 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.