Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage for OUTLETS INP section #229

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Add coverage for OUTLETS INP section #229

merged 6 commits into from
Nov 27, 2024

Conversation

aerispaha
Copy link
Member

@aerispaha aerispaha commented Nov 27, 2024 •
edited
Loading

Adds coverage for the [OUTLETS] INP section. Now we can get a dataframe of the OUTLETS section in models with model.inp.outlets. The higher level API now also include outlets in the model.links accessor.

Partially addresses #57

@aerispaha aerispaha self-assigned this Nov 27, 2024
@aerispaha aerispaha marked this pull request as ready for review November 27, 2024 17:18
@bemcdonnell
Copy link
Member

@aerispaha achhoooooooAnyUnitTests ?

@aerispaha
Copy link
Member Author

@bemcdonnell heck yeah. I've added a doctest for inp.outlets, so we get a little bit of docs and a test (two rocks with one bird)

@aerispaha
Copy link
Member Author

this is @bemcdonnell right now
image

@aerispaha aerispaha merged commit 93148c0 into master Nov 27, 2024
17 checks passed
@bemcdonnell
Copy link
Member

@aerispaha my beard isn't as gray as yours!!

@aerispaha aerispaha deleted the feature/add-outlets branch November 27, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bemcdonnell bemcdonnell bemcdonnell approved these changes

Assignees

@aerispaha aerispaha

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aerispaha @bemcdonnell