-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile wrapup #173
Profile wrapup #173
Conversation
[TIMESERIES] | ||
;;Name Date Time Value | ||
;;-------------- ---------- ---------- ---------- | ||
10002_TimeSeries 10/01/2016 00:00 0.000356481487475 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bemcdonnell do we need this timeseries in the inp for the unit tests? if not, can we drop this, just to keep the file size down a bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aerispaha probably not hugely required. I could remove if you would like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bemcdonnell awesome, thank you!
5d8361f
to
8b80f61
Compare
@aerispaha I force pushed the reduced lines... didn't know you were working on it :) |
awesome, thanks! love that commit message btw :) |
@aerispaha Do you want to drop appveyor soon? |
@bemcdonnell re: appveyor, yes I would like to drop appveyor soon. Just need to port over the deploy logic such that we can automatically post new versions to PyPI on tagged versions |
let's raise that in a separate issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
party on 🥳
thanks for this contribution, @bemcdonnell !
[TIMESERIES] | ||
;;Name Date Time Value | ||
;;-------------- ---------- ---------- ---------- | ||
10002_TimeSeries 10/01/2016 00:00 0.000356481487475 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bemcdonnell awesome, thank you!
@aerispaha happy to help! |
Here it is! #175 |
Closes #172