Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile wrapup #173

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Profile wrapup #173

merged 3 commits into from
Jan 4, 2023

Conversation

bemcdonnell
Copy link
Member

Closes #172

@bemcdonnell bemcdonnell marked this pull request as ready for review December 30, 2022 11:47
@bemcdonnell
Copy link
Member Author

test_weir
Here is what I ended up doing with Weirs.

@bemcdonnell bemcdonnell added this to the v1.0 milestone Dec 30, 2022
@bemcdonnell bemcdonnell self-assigned this Dec 30, 2022
[TIMESERIES]
;;Name Date Time Value
;;-------------- ---------- ---------- ----------
10002_TimeSeries 10/01/2016 00:00 0.000356481487475
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bemcdonnell do we need this timeseries in the inp for the unit tests? if not, can we drop this, just to keep the file size down a bit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aerispaha probably not hugely required. I could remove if you would like

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bemcdonnell awesome, thank you!

@bemcdonnell
Copy link
Member Author

@aerispaha I force pushed the reduced lines... didn't know you were working on it :)

@aerispaha
Copy link
Member

pushed the reduced lines... didn't know you were working on it

awesome, thanks! love that commit message btw :)

@bemcdonnell
Copy link
Member Author

@aerispaha Do you want to drop appveyor soon?

@aerispaha
Copy link
Member

@bemcdonnell re: appveyor, yes I would like to drop appveyor soon. Just need to port over the deploy logic such that we can automatically post new versions to PyPI on tagged versions

@bemcdonnell
Copy link
Member Author

let's raise that in a separate issue.

Copy link
Member

@aerispaha aerispaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

party on 🥳
thanks for this contribution, @bemcdonnell !

[TIMESERIES]
;;Name Date Time Value
;;-------------- ---------- ---------- ----------
10002_TimeSeries 10/01/2016 00:00 0.000356481487475
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bemcdonnell awesome, thank you!

@aerispaha aerispaha merged commit ed160a9 into master Jan 4, 2023
@bemcdonnell bemcdonnell deleted the profile_wrapup branch January 4, 2023 20:29
@bemcdonnell
Copy link
Member Author

@aerispaha happy to help!

@aerispaha
Copy link
Member

let's raise that in a separate issue.

Here it is! #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Profile Plot feature
2 participants