Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify mistune==0.8.4 to control m2r depency verssion #129

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

aerispaha
Copy link
Member

@aerispaha aerispaha commented Feb 9, 2022

Controls the mistune version (a dependency of m2r) to prevent the 'mistune' has no attribute 'BlockGrammar' error

Closes #128

@aerispaha aerispaha self-assigned this Feb 9, 2022
@aerispaha aerispaha requested a review from jennwuu February 9, 2022 18:02
@jennwuu
Copy link
Contributor

jennwuu commented Feb 9, 2022

@aerispaha
Copy link
Member Author

aerispaha commented Feb 9, 2022

@aerispaha do you need to update install_requires in setup.py?

@jennwuu, I don't think so.

The mistune and m2r dependencies are only necessary for building the sphinx docs. I don't think a typical user would need to install those when running pip install swmmio, unless they wanted to build the docs locally. But I feel like that isn't really necessary since the docs are hosted publicly on readthedocs.

Does that make sense to you?

@jennwuu
Copy link
Contributor

jennwuu commented Feb 9, 2022

@aerispaha yup, that makes sense to me! Thanks for explaining.

@aerispaha aerispaha merged commit 36403f8 into master Feb 9, 2022
@aerispaha aerispaha deleted the fix182 branch February 9, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs build fails due to m2r dependency
2 participants